add pytest extra args option #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
approved these changes
Nov 3, 2022
.github/workflows/main.yaml
Outdated
| @@ -165,7 +169,8 @@ jobs: | |||
| --cov=pytest_pyodide \ | |||
| --dist-dir=./pyodide-dist/ \ | |||
| --runner=${{ inputs.runner }} \ | |||
| --rt ${{ inputs.browser }} | |||
| --rt ${{ inputs.browser }} \ | |||
There was a problem hiding this comment.
Suggested change
| --rt ${{ inputs.browser }} \ | |
| --rt=${{ inputs.browser }} \ |
Without this, pytest-extra-args will be push to runtime list
There was a problem hiding this comment.
Oh, okay this change breaks one test, which passes multiple browsers to inputs.browser. I think I added that to test whether --rt correctly handles multiple parameters. But I think we can remove that test from filtermatrix.py, regarding that users who use this action don't need that test.
Co-authored-by: Gyeongjae Choi <[email protected]>
bwoodsend
pushed a commit
to ultrajson/ultrajson
that referenced
this pull request
Nov 3, 2022
Doing so allows for building on webassembly. Officially declareing support for WASM however will have to wait until pyodide/pytest-pyodide#59 is merged to facilitate testing WASM compatibility.
|
What's the status of this PR? Do we still want it or is now handled by |
|
I'll open a PR that fixes the failing test suite, then we can merge this. This isn't related to pyodide-actions I think. |
|
Thanks @joemarshall! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to the reusable main action for extra args to pass to pytest. Without that it isn't possible to e.g. filter out non-pyodide test python files.